Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #744, Setting month and year before setting date solves the issue #745

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #744, Setting month and year before setting date solves the issue #745

wants to merge 1 commit into from

Conversation

technoknol
Copy link

Description

  1. Setting month and year before setting date solves the issue
  2. Included test case for Date issue for month having 31 days #744.

Motivation and Context

Checklist

[x] I have not included any built dist files (us maintainers do that prior to a new release)
[x] I have added tests covering my changes
[x] All new and existing tests pass
[ ] My changes required the documentation to be updated
  [ ] I have updated the documentation accordingly
  [ ] I have updated the TypeScript 1.8 type definitions accordingly
  [ ] I have updated the TypeScript 2.0+ type definitions accordingly

@technoknol
Copy link
Author

Test fails because of dist files are older ones. I've tested it with new build and it works.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@technoknol